Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong counter color in jump-to screen #17554

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Oct 5, 2023

fixes: #17553

Testing (Design)

In the design review, both the bottom nav and top bar counter color are reported as wrong, but I tried printing color and using a color picker and it looks like the top bar in the jump-to screen is using the right color. Maybe it is fixed in develop after release. Please let me know if this is not the case

status: ready

@Parveshdhull Parveshdhull self-assigned this Oct 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Oct 5, 2023

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fde1cfa #1 2023-10-05 08:56:11 ~6 min android 🤖apk 📲
✔️ fde1cfa #1 2023-10-05 08:56:19 ~6 min ios 📱ipa 📲
✔️ fde1cfa #1 2023-10-05 08:56:22 ~6 min android-e2e 🤖apk 📲
✔️ fde1cfa #1 2023-10-05 08:59:35 ~9 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5fa6087 #2 2023-10-05 09:07:06 ~5 min android-e2e 🤖apk 📲
✔️ 5fa6087 #2 2023-10-05 09:07:16 ~6 min ios 📱ipa 📲
✔️ 5fa6087 #2 2023-10-05 09:10:37 ~9 min android 🤖apk 📲
✔️ 5fa6087 #2 2023-10-05 09:10:41 ~9 min tests 📄log
✔️ 3a12952 #3 2023-10-05 11:28:59 ~6 min android 🤖apk 📲
✔️ 3a12952 #3 2023-10-05 11:30:40 ~7 min ios 📱ipa 📲
✔️ 3a12952 #3 2023-10-05 11:32:08 ~9 min android-e2e 🤖apk 📲
✔️ 3a12952 #3 2023-10-05 11:32:17 ~9 min tests 📄log

@status-im-auto
Copy link
Member

70% of end-end tests have passed

Total executed tests: 43
Failed tests: 13
Passed tests: 30
IDs of failed tests: 703194,702859,702732,703495,702948,702745,702783,703297,703503,703391,702786,702731,702808 

Failed tests (13)

Click to expand
  • Rerun failed tests

  • Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Tap on found: Button
    Device 1: Find `Button` by `xpath`: `//*[@text="Contributors' test community"]`

    critical/test_public_chat_browsing.py:338: in test_community_discovery
        self.home.element_by_text(contributors_test_community_attributes[0]).click()
    ../views/base_element.py:90: in click
        self.find_element().click()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[@text="Contributors' test community"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception 
    

    [[Request to Join Community button color issue:17295]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194

    Device 2: Looking for a message by text: gallery
    Device 2: Trying to access images (image container) inside message with text 'gallery'

    critical/test_public_chat_browsing.py:674: in test_community_several_images_send_reply
        if chat_element.image_container_in_message.is_element_differs_from_template(file_name, 5):
    ../views/base_element.py:268: in is_element_differs_from_template
        self.template = file_name
    ../views/base_element.py:239: in template
        self.__template = Image.open(os.sep.join(__file__.split(os.sep)[:-1]) + '/elements_templates/%s' % value)
    /home/jenkins/.local/lib/python3.10/site-packages/PIL/Image.py:2958: in open
     cannot identify image file '/home/jenkins/workspace/status-mobile/e2e/status-app-prs/test/appium/views/elements_templates/gallery_1.png'
    



    Device sessions

    2. test_community_one_image_send_reply, id: 702859

    Device 2: Looking for a message by text: description
    Device 2: Trying to access image inside message with text 'description'

    critical/test_public_chat_browsing.py:716: in test_community_one_image_send_reply
        image_description).image_in_message.is_element_image_similar_to_template('image_sent_in_community.png'):
    ../views/base_element.py:280: in is_element_image_similar_to_template
        template = imagehash.average_hash(Image.open(image_template))
    /home/jenkins/.local/lib/python3.10/site-packages/PIL/Image.py:2958: in open
     cannot identify image file '/home/jenkins/workspace/status-mobile/e2e/status-app-prs/test/appium/views/elements_templates/image_sent_in_community.png'
    



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent

    critical/chats/test_1_1_public_chats.py:1417: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Message status was not changed to Delivered, it's Sent after back up online! 
    

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Find ProfilePictureElement by accessibility id: chat-icon
    Device 1: Tap on found: ProfilePictureElement

    critical/chats/test_1_1_public_chats.py:1087: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        self.profile_1.edit_profile_picture('sauce_logo.png')
    ../views/profile_view.py:427: in edit_profile_picture
        self.profile_picture.template = file_name
    ../views/base_element.py:239: in template
        self.__template = Image.open(os.sep.join(__file__.split(os.sep)[:-1]) + '/elements_templates/%s' % value)
    /home/jenkins/.local/lib/python3.10/site-packages/PIL/Image.py:2958: in open
     cannot identify image file '/home/jenkins/workspace/status-mobile/e2e/status-app-prs/test/appium/views/elements_templates/sauce_logo.png'
    



    Device sessions

    2. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Looking for a message by text: test image
    Device 2: Trying to access image inside message with text 'test image'

    critical/chats/test_1_1_public_chats.py:1224: in test_1_1_chat_send_image_save_and_share
        image_description).image_in_message.is_element_image_similar_to_template('saucelabs_sauce_chat.png'):
    ../views/base_element.py:280: in is_element_image_similar_to_template
        template = imagehash.average_hash(Image.open(image_template))
    /home/jenkins/.local/lib/python3.10/site-packages/PIL/Image.py:2958: in open
     cannot identify image file '/home/jenkins/workspace/status-mobile/e2e/status-app-prs/test/appium/views/elements_templates/saucelabs_sauce_chat.png'
    



    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     New messages counter near chats tab button is 1 after unmute, but should be 2
    



    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297

    # STEP: Admin checks image message
    Device 1: Looking for a message by text: test image

    critical/chats/test_group_chat.py:357: in test_group_chat_send_image_save_and_share
        self.chats[0].chat_element_by_text(image_description).wait_for_visibility_of_element(60)
    ../views/base_element.py:139: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    4. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member

    critical/chats/test_group_chat.py:443: in test_group_chat_offline_pn
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Messages PN was not fetched from offline 
    

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: #cats

    critical/test_public_chat_browsing.py:1283: in test_community_hashtag_links_to_community_channels
        self.channel_2.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body()
    ../views/chat_view.py:188: in click_on_link_inside_message_body
        self.message_body.wait_for_visibility_of_element(30)
    ../views/base_element.py:139: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2'

    critical/test_public_chat_browsing.py:1167: in test_community_mentions_push_notification
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Can not edit a message with a mention
    E    Push notification with the mention was not received by the invited member 
    

    [[Issue with username in PN 17396]]

    Device sessions

    Passed tests (30)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good now :)

    @Parveshdhull Parveshdhull force-pushed the fix/jump-to-design-review branch from 5fa6087 to 3a12952 Compare October 5, 2023 11:22
    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented Oct 5, 2023

    1. test_group_chat_mute_chat
      New messages counter near chats tab button is 1 after unmute, but should be 2

    (not sure if its known, or caused by PR)

    @status-im/mobile-qa, Please can you check failed tests

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Oct 5, 2023

    (not sure if its known, or caused by PR)

    yeah it's known, e2e failures are not related to the PR changes @Parveshdhull

    @Parveshdhull Parveshdhull merged commit c2833ae into develop Oct 5, 2023
    2 checks passed
    @Parveshdhull Parveshdhull deleted the fix/jump-to-design-review branch October 5, 2023 13:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    Archived in project
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Wrong counter color in jump-to screen
    5 participants