-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong counter color in jump-to screen #17554
Conversation
Jenkins BuildsClick to see older builds (4)
|
src/status_im2/contexts/shell/jump_to/components/bottom_tabs/view.cljs
Outdated
Show resolved
Hide resolved
70% of end-end tests have passed
Failed tests (13)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (30)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now :)
5fa6087
to
3a12952
Compare
(not sure if its known, or caused by PR) @status-im/mobile-qa, Please can you check failed tests |
yeah it's known, e2e failures are not related to the PR changes @Parveshdhull |
fixes: #17553
Testing (Design)
In the design review, both the bottom nav and top bar counter color are reported as wrong, but I tried printing color and using a color picker and it looks like the top bar in the jump-to screen is using the right color. Maybe it is fixed in develop after release. Please let me know if this is not the case
status: ready